Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lab snippet lore update #36497

Merged
merged 14 commits into from
Jan 4, 2020
Merged

Lab snippet lore update #36497

merged 14 commits into from
Jan 4, 2020

Conversation

I-am-Erk
Copy link
Member

@I-am-Erk I-am-Erk commented Dec 28, 2019

Summary

SUMMARY: Content "Updates lore in lab terminals"

Purpose of change

Flyers, newspapers, and lab terminal snippets are getting out of date to the lore in game currently. For example, flyers are largely devoted to advertising CBMs that are rare at the consumer level, if they're available at all.

Describe the solution

Goes through and cleans up, updates, and expands lab terminals.

While I'm there, I also moved radio chatter to a new file. No changes were made to content or layout at this time.

Describe alternatives you've considered

Initially I split the lore addition by types of lab they come from. This will require some infrastructure changes to make it work as I want though, so I saved that work but reverted to the original format.

Testing

wip

@I-am-Erk I-am-Erk added the [JSON] Changes (can be) made in JSON label Dec 28, 2019
@RafeHaab
Copy link
Contributor

Can I help?

@I-am-Erk
Copy link
Member Author

Thanks for the offer but it's not really a two person job right now

@I-am-Erk I-am-Erk changed the title WIP: Lab snippet lore update Lab snippet lore update Jan 4, 2020
@I-am-Erk I-am-Erk marked this pull request as ready for review January 4, 2020 06:26
Co-Authored-By: Tonkatsu <[email protected]>
Co-Authored-By: ZhilkinSerg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants