Add construction recipe to turn shallow water to dirt. #36493
Conversation
Apparently, no one has done this before, and I really need to tame those swamps. As my first project, please do check everything is ok.
curstwist
added
[JSON]
thanks Co-Authored-By: I-am-Erk <[email protected]>
|
by the way, this only works on salt water terrain. swamps also have fresh water Is it intended that you only want it to work on salt water? |
|
Actually, it was an oversight on my part; didn't realize "swater_sh" meant "saltwater"; It now should work with both. |
Apparently I'm not skilled enough to properly format my pull requests, and the rest of the construction options aren't helping me find out how to do it. The good thing is that now you'll know which kind of shallow water you are going to refill, thus making them harder to mix up.
data/json/construction.json
Outdated
| { | ||
| "type": "construction", | ||
| "description": "Fill Salt Water With Dirt", | ||
| "//": "Fills a salt water with dirt.", |
There was a problem hiding this comment.
This comment just repeats the description of the construction. Why is it there? Same with the comment of the other construction.
There was a problem hiding this comment.
I don't know how to put two required terrain options in the same project.
There was a problem hiding this comment.
I'm not concerned about the two constructions (that is fine, a limitation of the game).
I'm talking about the comments: the "//": "..." things. They are comments, so they are ignored by program anyway. In other words: they are unnecessary as (in their current state) they don't add any information. I suggest you remove them.
There was a problem hiding this comment.
Is it good enough for merging now?
|
I'd really like to see this allow at least sand as an alternate to dirt. |
Co-Authored-By: I-am-Erk <[email protected]>
Apparently, no one has done this before, and I really need to tame those swamps.
As my first project, please do check everything is ok.
Summary
SUMMARY: Features "Adds a way to fill shallow water to turn them into dirt tiles via the construction menu."Purpose of change
Fixes swamps being basically useless by letting players get rid of all the water #36493
Describe the solution
Adds a new construction project
Describe alternatives you've considered
Honestly, this is simple enough that it shouldn't require lateral thinking
Testing
Additional context