Extended pickup window

[8street]

Summary

SUMMARY: Interface "Extended pickup window"

Purpose of change

Now it’s very convenient to pick up items. Full and not cropped item names are displayed.

Describe the solution

The width of the pickup window was the fixed width. Now the pickup windows width is variable. The cycle searches for the maximum length of the item name. If item's name exceed the standard pickup window width (44 symbols) then window width equal item's name.
There is also a check for exceeding the lenght of the item's name with the width of the game window.

Describe alternatives you've considered

#36102 but this closed. The current solution really looks better.

Testing

[Night-Pryanik]

Could you please show a screenshot of right-aligned pickup window with your changes?

[8street]

Right aligned

Overlapping

[8street]

Travis Clang-tidy CMake build with Tiles and Sound error:

/home/travis/build/CleverRaven/Cataclysm-DDA/src/pickup.cpp:571:9: error: use range-based for loop instead [modernize-loop-convert,-warnings-as-errors]
        for( size_t cur_it = 0; cur_it < stacked_here.size(); cur_it++ ) {
        ^  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
           (auto & cur_it : stacked_here)

It's my changes but I don't know what it means. Does anyone know how to fix this?

The code also nearby has a similar cycle, it works.
for( size_t index = 0; index < stacked_here.size(); index++ ) {

[Qrox]

cur_it in your code is only used to access the elements of stacked_here, so it can be simplified to a range-based for loop. You only need to change

        for( size_t cur_it = 0; cur_it < stacked_here.size(); cur_it++ ) {
            const item &this_item = *stacked_here[cur_it].front();

to

        for( const std::list<item_stack::iterator> &cur_list : stacked_here ) {
            const item &this_item = *cur_list.front();

[8street]

Thanks. This solution seems to work. I mean, it works on my local pc. Although, I can’t check it there. Someone has broken the code style and the necessary Travis build does not start.

[8street]

Tests passed. Pull request can be merged.