Fix riot turret oversights #36437
Merged
Fix riot turret oversights #36437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZhilkinSerg
added
<Bugfix>
|
Huh, I guess I always envisioned these things with an internal magazine and autoloader. 6 rounds seems like not enough. But hey, realistic, I like that! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Fix inconsistencies in riot turrets"
Purpose of change
Riot turrets were introduced with a new 40x46mm item that duplicated M1006. The turret itself was explicitly SWORDS derived but did not behave as such and the description for the M203 array was inconsistent with behavior.
Describe the solution
Use M1006 where appropriate, remove duplicate item, adjust numbers and descriptions for riot turrets. Remove unused
mon_chickenbotandmon_tankbotdefinitions in map_extras.cpp.Testing
Game loads correctly. Riot turret behaves as expected.
Additional context
It should be possible to define the starting ammo item for a monster in mapgen when it's placed. There's also no reason this thing couldn't be loaded with any 40x46mm ammo. We should have infrastructure to support these.