Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Honey does not rot #36432

Closed
wants to merge 1 commit into from
Closed

Honey does not rot #36432

wants to merge 1 commit into from

Conversation

Jerimee
Copy link
Contributor

@Jerimee Jerimee commented Dec 25, 2019

Summary

SUMMARY: Content "honey no longer rots"

Purpose of change

Mark rotting false, despite edible being true, for honey.

Describe alternatives you've considered

Perhaps I've misunderstood what rotting boolean is meant to flag.

Testing

None!

Additional context

Shelf life for commercial honey has been established at around two years (essentially forever in game time). Honey stored in sealed containers can remain stable for decades and even centuries!

Materials with edible true almost always have rotting true. Rare exceptions might include salt, honey, some grains (rice?), mable syrup, vinegar, and arguably leather.

@kevingranade
Copy link
Member

There is no such thing as "essentially forever in game time", if it takes 10 years to degrade, we make it take 10 years to degrade.

@Jerimee
Copy link
Contributor Author

Jerimee commented Dec 25, 2019

Does it then follow that when edible is true, rotting should always be true?

@Zireael07
Copy link
Contributor

Salt, leather and probably vinegar do not rot, so it's not a true assumption.

@Jerimee
Copy link
Contributor Author

Jerimee commented Dec 25, 2019

A quick google: Table salt has a shelf life of 5 years, and white vinegar is like honey; it lasts 100+ years if stored properly. But I think materials is either storage neutral or, more likely, implies no storage.

On this point I'm highly confused, as liquids without a container diffuse immediately and evaporate quickly. I'll try to get clarification on how the code works and then update the doc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants