-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retroday outline #36402
Closed
Closed
Retroday outline #36402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Jianxiang Wang (王健翔) <[email protected]>
Co-Authored-By: Jianxiang Wang (王健翔) <[email protected]>
Co-Authored-By: Jianxiang Wang (王健翔) <[email protected]>
Co-Authored-By: Jianxiang Wang (王健翔) <[email protected]>
Co-Authored-By: Jianxiang Wang (王健翔) <[email protected]>
Co-Authored-By: Jianxiang Wang (王健翔) <[email protected]>
Co-Authored-By: Jianxiang Wang (王健翔) <[email protected]>
Co-Authored-By: Jianxiang Wang (王健翔) <[email protected]>
Co-Authored-By: Jianxiang Wang (王健翔) <[email protected]>
oh, it seems i mixed the git commit ? |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Interface "add transparency to retrodays"
Purpose of change
retrodays tileset is my favourite but, all the tiles have a black background thus rendering all objects like a black square with the object drawn on that.
the problem is, when you have and object on top of a larger one, like a lighter on a table,
the lighter gfx and its black square background, prevent you to see the table underneath.
it make it look like the table is missing a whole chunk. to the point that if there is few objects (3 or 4) on the table you cannot distinguish there's a table at all.
so i removed the black squares, and left instead a black outline around the contours of the objects.
other tilesets have transparency, so i made it for retrodays too.
Describe the solution
i removed black squares around tiles, and left a black outline instead.
Testing
i have been playing with that for quite some time.
Additional context
in general look for objects on top of bigger objects, like the tables and sofas:
before:
after:
tiles: