Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix NPC forgetting they are your followers #36391

Merged
merged 1 commit into from Dec 24, 2019
Merged

fix NPC forgetting they are your followers #36391

merged 1 commit into from Dec 24, 2019

Conversation

ghost
Copy link

@ghost ghost commented Dec 23, 2019

Summary

SUMMARY: Bugfixes "fix NPC forgetting they are your followers"

Purpose of change

Fixes #36386

Describe the solution

As per the linked issue , and the details in there.

Describe alternatives you've considered

N/A

Testing

Despite not having exact repro steps for the linked issue, I have strong suspicions its down to this problem,and even its not, this needs to be fixed anyway.
As it causes NPCs to forget they are your followers briefly when told to stop guarding under certain conditions. - the step between that stage and them leaving your faction, is probably down to the user telling the NPC they are "going to go their own way" which dosnt actually change the chatbin topic, therefore creating the impression they are still half a follower.

Additional context

N/A

@ZhilkinSerg ZhilkinSerg added <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` NPC / Factions NPCs, AI, Speech, Factions, Ownership labels Dec 24, 2019
@ZhilkinSerg ZhilkinSerg merged commit c956a9e into CleverRaven:master Dec 24, 2019
@ghost ghost deleted the npc_not_followers branch January 17, 2020 10:01
@ZhilkinSerg ZhilkinSerg mentioned this pull request Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` NPC / Factions NPCs, AI, Speech, Factions, Ownership
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NPC followers stopped being friendly.
1 participant