Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor wield contents #36369

Merged
merged 1 commit into from
Dec 24, 2019

Conversation

KorGgenT
Copy link
Member

Summary

SUMMARY: Infrastructure "refactor player::wield_contents"

Purpose of change

To reduce the usage of int pos and use an item pointer instead. an item_location would also technically work here, but it is known that it is part of character.

Testing

spawned toolbelt, filled it with hammers, and then pulled them out.

Additional context

This will get revisited later when i refactor item_contents, but this is the bare minimum needed to get all that stuff done.

@KorGgenT KorGgenT added [C++] Changes (can be) made in C++. Previously named `Code` Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style labels Dec 23, 2019
@KorGgenT KorGgenT force-pushed the refactor-wield-contents branch from 077ebe6 to 7d79219 Compare December 23, 2019 06:03
@KorGgenT KorGgenT changed the title refactor wield contents WIP refactor wield contents Dec 23, 2019
@KorGgenT KorGgenT force-pushed the refactor-wield-contents branch from 7d79219 to 696880f Compare December 23, 2019 15:30
@KorGgenT KorGgenT changed the title WIP refactor wield contents refactor wield contents Dec 23, 2019
@kevingranade kevingranade merged commit 82cb0bf into CleverRaven:master Dec 24, 2019
@KorGgenT KorGgenT deleted the refactor-wield-contents branch August 13, 2020 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C++] Changes (can be) made in C++. Previously named `Code` Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants