Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ankle socks #36347

Merged
merged 13 commits into from
Dec 28, 2019
Merged

Ankle socks #36347

merged 13 commits into from
Dec 28, 2019

Conversation

FuelType-Memes
Copy link
Contributor

Summary

SUMMARY: Content "Adds new item 'Ankle socks'"

Purpose of change

Ankle socks are popular type of socks, used for sports and with some footwear. I also wanted an alternative to socks that I can wear in the summer, so those provide no warmth bonus

Describe the solution

Added a new item, a recipe for said item. Modified loot tables and also some starting "sports" professions

Describe alternatives you've considered

Going sockless in summer and RUINING immersion

Testing

Game compiles. Spawned in new socks, crafted them. Spawned as a bionic runner to test professions

Additional context

My first item addition!

@curstwist curstwist added [JSON] Changes (can be) made in JSON Items / Item Actions / Item Qualities Items and how they work and interact labels Dec 27, 2019
@I-am-Erk
Copy link
Member

Needs linting

@I-am-Erk I-am-Erk merged commit 941f00f into CleverRaven:master Dec 28, 2019
@FuelType-Memes FuelType-Memes deleted the ankle-socks branch December 28, 2019 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Items / Item Actions / Item Qualities Items and how they work and interact [JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants