Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable -Wsuggest-override #36343

Merged
merged 1 commit into from
Dec 22, 2019
Merged

Enable -Wsuggest-override #36343

merged 1 commit into from
Dec 22, 2019

Conversation

Qrox
Copy link
Contributor

@Qrox Qrox commented Dec 22, 2019

Summary

SUMMARY: None

Purpose of change

Enable GCC's -Wsuggest-override so overridden functions are always marked with override.

Testing

Removed an override identifier and confirmed that GCC reported the missing identifier.

@ZhilkinSerg
Copy link
Contributor

error: unknown warning option '-Wsuggest-override'; did you mean

  '-Wshift-overflow'? [-Werror,-Wunknown-warning-option]

@ZhilkinSerg ZhilkinSerg added the Code: Build Issues regarding different builds and build environments label Dec 22, 2019
@kevingranade kevingranade merged commit 46c0151 into CleverRaven:master Dec 22, 2019
@Qrox Qrox deleted the suggest-override branch December 23, 2019 07:38
@weekly-digest weekly-digest bot mentioned this pull request Dec 29, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Code: Build Issues regarding different builds and build environments
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Qrox @ZhilkinSerg @kevingranade