Lower the range of dirt guns spawn with #36341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Very very few guns should be fouled heavily, or fouled at all. However, because the amount of dirt guns spawn with is simply a number between the min an max defined here, having a range this high leads to most guns being fouled or fairly heavily fouled. Adjust this range back to what is was previously, which leads to most guns being very lightly fouled or not noticeably fouled. Itemgroups can still override this, and make guns spawn with more fouling.
ZhilkinSerg
added
[C++]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: None
Purpose of change
Very very few guns should be fouled heavily, or fouled at all. However, because the amount of dirt guns spawn with is simply a number between the min an max defined here, having a range this high leads to most guns being fouled or fairly heavily fouled.
Describe the solution
Adjust this range back to what is was previously, which leads to most guns being very lightly fouled or not noticeably fouled. Itemgroups can still override this, and make guns spawn with more fouling.
Testing
Before
After
I hope the fouling levels on the before guns show why this change is necessary. Most of these guns are very heavily fouled.
Additional context
This is effectively reverting the changes made to this in #34470. I'm sure there was a reason for this change, but I cannot find any commentary on it in the PR.