Use volume strings in mods #36329
Merged
Use volume strings in mods #36329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KorGgenT
reviewed
Dec 21, 2019
| @@ -35,7 +35,7 @@ | |||
| "skill": "pistol", | |||
| "ammo": "454", | |||
| "weight": 1500, | |||
| "volume": 2, | |||
There was a problem hiding this comment.
it looks like this doesn't quite work
There was a problem hiding this comment.
That's due to the built in mod.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: None
Purpose of change
Volume strings provide units and are more easily readable than ints.
Describe the solution
Run
tools/json_tools/cddaUpdateVolume.jsondata/modsTesting
Ran the data loading with non-blacklisted mods using the tests