more variety is SUS shelter items

[Jerimee]

Summary

SUMMARY: None

Purpose of change

Increase the number of items that spawn in the default start shelter.

Describe the solution

The biggest changes are that FEMA now regularly stocks plastic ponchos and the SUS locker specification now include a whistle. There are rare instances where a head lamp, a mirror, a jug of vinegar, or a barometer might be found.

Testing

Tested locally with "Test Item Group" debug tool

Additional context

This PR is similar to #36282 - however, if modifies the SUS tables, and it's effects are more muted.

[I-am-Erk]

I like the additions in general but I'm a bit confused by some of your changes here.

[Jerimee]

I must have confused distribution and collection. I will untweak the numbers.

…

On Fri, Dec 20, 2019, 10:29 AM John Candlebury ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In data/json/itemgroups/SUS/evac_shelter.json <#36284 (comment)> : > { "item": "mask_gas", "prob": 2 }, - { "item": "flashlight", "prob": 50 }, + { "item": "flashlight", "prob": 48 }, Collection spawning probabilities don’t work like that. The game goes through the whole list. With every entry having an independent chance/100 probability of being spawned. Removing the 12 points from the other entries is unnecessary. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#36284?email_source=notifications&email_token=AAU2VNKJPP3OXEDKRQ5EYDDQZTQELA5CNFSM4J5WSTTKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCP6JWDQ#discussion_r360421435>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAU2VNIND2LJACCXSG7LTJTQZTQELANCNFSM4J5WSTTA> .

[Jerimee]

ZS yeah I read that but then I got it twisted. Erk, yeah that collection's theme was "less likely items," "new stuff Jerimee just added," or "things more likely to have been looted already" - not wedded to it

…

On Fri, Dec 20, 2019, 1:22 PM ZhilkinSerg ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In data/json/itemgroups/SUS/evac_shelter.json <#36284 (comment)> : > { "item": "mask_gas", "prob": 2 }, - { "item": "flashlight", "prob": 50 }, + { "item": "flashlight", "prob": 48 }, https://github.com/CleverRaven/Cataclysm-DDA/blob/master/doc/ITEM_SPAWN.md#collection-or-distribution — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#36284?email_source=notifications&email_token=AAU2VNP2K7D5VF3NYS4FYETQZUEOPA5CNFSM4J5WSTTKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCP7FK2I#discussion_r360509158>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAU2VNICMOZEMMUD6LICGXLQZUEOPANCNFSM4J5WSTTA> .

[Jerimee]

ZS, nevermind the chart is correct. On Fri, Dec 20, 2019, 2:40 PM Jerimee Richir <[email protected]> wrote:

…

ZS yeah I read that closely - does the chart match the text? I feel like the text says one thing and the chart inverts it? Erk, yeah that collection's theme was "less likely items," "new stuff Jerimee just added," or "things more likely to have been looted already" - not wedded to it On Fri, Dec 20, 2019, 1:22 PM ZhilkinSerg ***@***.***> wrote: > ***@***.**** commented on this pull request. > ------------------------------ > > In data/json/itemgroups/SUS/evac_shelter.json > <#36284 (comment)> > : > > > { "item": "mask_gas", "prob": 2 }, > - { "item": "flashlight", "prob": 50 }, > + { "item": "flashlight", "prob": 48 }, > > > https://github.com/CleverRaven/Cataclysm-DDA/blob/master/doc/ITEM_SPAWN.md#collection-or-distribution > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <#36284?email_source=notifications&email_token=AAU2VNP2K7D5VF3NYS4FYETQZUEOPA5CNFSM4J5WSTTKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCP7FK2I#discussion_r360509158>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAU2VNICMOZEMMUD6LICGXLQZUEOPANCNFSM4J5WSTTA> > . >