Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add rings and bracelets #36278

Merged
merged 4 commits into from
Dec 21, 2019
Merged

Conversation

curstwist
Copy link
Contributor

Summary

SUMMARY: Content "Adds gem stone rings and braclets."

Purpose of change

continue jewelry expansion.

Describe the solution

add more.

Testing

loaded world, spawned items, checked looks_like and did spawn checks with debug and in game spawns for item_groups.

@Jerimee
Copy link
Contributor

Jerimee commented Dec 20, 2019

At the risk of being trifling, is it desirable that aquamarine_gold_bracelet be given the same probability as ruby_ or emerald_? My understanding is that some precious stones are rarer than others.

@curstwist
Copy link
Contributor Author

curstwist commented Dec 20, 2019

At the risk of being trifling, is it desirable that aquamarine_gold_bracelet be given the same probability as ruby_ or emerald_? My understanding is that some precious stones are rarer than others.

I'm not going to get into probabilities for spawns based on gem type. If someone else wants to get that detailed once they are all in, they are welcome to pursue it.

edit: to add to this reasoning, with the population decimated, I don't think their relative rarity will matter much, all these gems would still be represented in a jewelry store to some degree and their spawns aren't indicative of an entire store's stock. I went with the traditional birth stones which any jeweler should stock.

@curstwist curstwist added [JSON] Changes (can be) made in JSON Items / Item Actions / Item Qualities Items and how they work and interact labels Dec 20, 2019
@I-am-Erk
Copy link
Member

Can you please change these to use the new format for names, eg

    "name": { "str": "soap dish", "str_pl": "soap dishes" },

@curstwist
Copy link
Contributor Author

Can you please change these to use the new format for names, eg

    "name": { "str": "soap dish", "str_pl": "soap dishes" },

fixed, including the original PR of jewelry (earrings & dental grills)

@I-am-Erk I-am-Erk merged commit bfb1fcc into CleverRaven:master Dec 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Items / Item Actions / Item Qualities Items and how they work and interact [JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants