Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear screen after world/options menu close to clean up graphical artifacts #36257

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/options.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2691,6 +2691,7 @@ std::string options_manager::show( bool ingame, const bool world_options_only )
// keybinding screen erased the internal borders of main menu, restore it:
draw_borders_internal( w_options_header, mapLines );
} else if( action == "QUIT" ) {
catacurses::clear();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possibly it would be better to put catacurses::clear() before drawing certain screens instead of when exiting options screen as window would be cleared on "Save changes"/"Abort World generation " popups.

image

image

catacurses::refresh();
break;
}
Expand Down
1 change: 1 addition & 0 deletions src/worldfactory.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,7 @@ WORLDPTR worldfactory::make_new_world( bool show_prompt, const std::string &worl
}
}
if( curtab < 0 ) {
catacurses::clear();
catacurses::refresh();
return nullptr;
}
Expand Down