Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

20 or so fairy tale descriptions #36248

Merged
merged 8 commits into from
Dec 19, 2019
Merged

Conversation

Jerimee
Copy link
Contributor

@Jerimee Jerimee commented Dec 19, 2019

Summary

SUMMARY: Content "via book/misc.json added more than 20 different descriptions for fairy_tales books"

Purpose of change

Per the "List of easy jobs" I've added snippet descriptions to fairy tale books in the misc.json file.

Testing

I ran the game and spawned several "book of fairy tales." Indeed the descriptions were different. I also ran Jsonlint.

Additional context

One might expect the snippet ids to be sequential. Mine are unique but not sequential. Instead I used the snippet id to include meta data. The numbers correspond to the Aarne-Thompson-Uther System of folklore taxonomy.  

https://en.wikipedia.org/wiki/Aarne%E2%80%93Thompson%E2%80%93Uther_Index

Copy link
Member

@I-am-Erk I-am-Erk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few errors and then I'm happy to merge

@I-am-Erk I-am-Erk added [JSON] Changes (can be) made in JSON Items / Item Actions / Item Qualities Items and how they work and interact labels Dec 19, 2019
@Jerimee
Copy link
Contributor Author

Jerimee commented Dec 19, 2019

Thanks @I-am-Erk ! I appreciate you

@I-am-Erk I-am-Erk merged commit cb68229 into CleverRaven:master Dec 19, 2019
@Jerimee Jerimee deleted the fairytale branch January 25, 2020 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Items / Item Actions / Item Qualities Items and how they work and interact [JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants