-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mi-go furnitures contain a fetid goop that can mask your scent #36160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than obliterating scent, I'd much prefer that any kind of masking reduces effective strength of scent. This is also complicated in that why would everything ignore the mi-go goop smell? If anything this makes your smell stronger, and as long as you aren't in a mi-go lair it's just as distinctive as smelling like a person. |
Yes, but also why would any creature follow that horrid smell? |
BevapDin
reviewed
Dec 16, 2019
BevapDin
reviewed
Dec 16, 2019
BevapDin
reviewed
Dec 16, 2019
curstwist
added
[C++]
Changes (can be) made in C++. Previously named `Code`
<Enhancement / Feature>
New features, or enhancements on existing
[JSON]
Changes (can be) made in JSON
Mechanics: Character / Player
Character / Player mechanics
labels
Dec 16, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[C++]
Changes (can be) made in C++. Previously named `Code`
<Enhancement / Feature>
New features, or enhancements on existing
[JSON]
Changes (can be) made in JSON
Mechanics: Character / Player
Character / Player mechanics
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Content "Add fetid goop that can change your scent"
Purpose of change
Add infrastructure for item to change the player scent
Add scents_ignored entry to mtype, list of scent ignored by a monster type.
Add fetid goop to migo location that can be used to get a scent that Mi-gos ignore
The effects last one hour, the scent can be washed away by water, using the goop makes you sick
Describe the solution
Implement change_scent_iuse
Add appropriate checks to revert scent to normal after a time or have the scent washed away by water
Implement scents_ignored
Describe alternatives you've considered
Testing
Use the goop
debug scent map to check the scent has change
Check that Migos don't follow the scent
Check that the palyer does get sick
Jump in water > scent returns to normal
Additional context
The criteria for water removing the scent is having 50% of max weetness on torso, I did not manage to get that from spending a short time under the rain, but jumping in deep water does the trick.
Sadly washing away the smell with water does not remove the side effect, I don't know how to make that work.