Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mi-go furnitures contain a fetid goop that can mask your scent #36160

Merged
merged 17 commits into from
Jan 4, 2020

Conversation

Fris0uman
Copy link
Contributor

@Fris0uman Fris0uman commented Dec 16, 2019

Summary

SUMMARY: Content "Add fetid goop that can change your scent"

Purpose of change

Add infrastructure for item to change the player scent
Add scents_ignored entry to mtype, list of scent ignored by a monster type.
Add fetid goop to migo location that can be used to get a scent that Mi-gos ignore
The effects last one hour, the scent can be washed away by water, using the goop makes you sick

Describe the solution

Implement change_scent_iuse
Add appropriate checks to revert scent to normal after a time or have the scent washed away by water
Implement scents_ignored

Describe alternatives you've considered

Testing

Use the goop
debug scent map to check the scent has change
Check that Migos don't follow the scent
Check that the palyer does get sick
Jump in water > scent returns to normal

Additional context

The criteria for water removing the scent is having 50% of max weetness on torso, I did not manage to get that from spending a short time under the rain, but jumping in deep water does the trick.
Sadly washing away the smell with water does not remove the side effect, I don't know how to make that work.

@kevingranade
Copy link
Member

Rather than obliterating scent, I'd much prefer that any kind of masking reduces effective strength of scent. This is also complicated in that why would everything ignore the mi-go goop smell? If anything this makes your smell stronger, and as long as you aren't in a mi-go lair it's just as distinctive as smelling like a person.

@Fris0uman
Copy link
Contributor Author

Fris0uman commented Dec 16, 2019

Yes, but also why would any creature follow that horrid smell?

src/iuse_actor.cpp Outdated Show resolved Hide resolved
src/iuse_actor.cpp Outdated Show resolved Hide resolved
src/iuse_actor.cpp Outdated Show resolved Hide resolved
@curstwist curstwist added [C++] Changes (can be) made in C++. Previously named `Code` <Enhancement / Feature> New features, or enhancements on existing [JSON] Changes (can be) made in JSON Mechanics: Character / Player Character / Player mechanics labels Dec 16, 2019
@ZhilkinSerg ZhilkinSerg merged commit 235601a into CleverRaven:master Jan 4, 2020
@Fris0uman Fris0uman deleted the goop branch January 4, 2020 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C++] Changes (can be) made in C++. Previously named `Code` <Enhancement / Feature> New features, or enhancements on existing [JSON] Changes (can be) made in JSON Mechanics: Character / Player Character / Player mechanics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants