Prevent slimespring spawning dehydration #35561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, slimesprings would spawn when you were above your healthy calories by a certain amount and the amount of water you had after it was processed through your digestive system would leave you with a thirst value less than 40. The hunger calculation didn't cause problems, but the thirst calculation did, because players could spawn lots of slimesprings, which would massively increase their thirst value, pushing them up to dehydrated. They were not actually dehydrated, because they had the water to recover in their digestive system, but nonetheless, this was a problem. This prevents that by also checking that the player's visible thirst value is less than a certain amount. It also makes it so that your 'true' thirst value must be -20 or less.
ZhilkinSerg
added
<Bugfix>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Fix slimespring spawning causing dehydration"
Purpose of change
Fixes #34628
Previously, slimesprings would spawn when you were above your healthy
calories by a certain amount and the amount of water you had after it
was processed through your digestive system would leave you with a
thirst value less than 40 (your 'true' thirst value).
The hunger calculation didn't cause problems, but the thirst calculation
did, because players could spawn lots of slimesprings, which would
massively increase their actual thirst value, pushing them up to dehydrated.
They were not actually dehydrated, because they had the water to recover
in their digestive system, but nonetheless, this was a problem.
Describe the solution
This prevents that by also checking that the player's visible thirst
value is less than a certain amount.
It also makes it so that your 'true' thirst value must be -20 or less.
Describe alternatives you've considered
A different number or not adjusting the necessary 'true' thirst value.
Testing
Created a character, took a lot of slime serum. Debugged pain, hunger, thirst, and fatigue back to 0.
Drank lots of water.
Noticed that I never became dehydrated, unlike before this change.