Fix failed crafts with 0 volume #35554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, in progress crafts that lose their last component still exist, but with a volume of 0 as there is nothing in them. I've added this fix where if a player/npc bungles a craft and loses the last component of it (and the craft had components to start with), the craft item is removed from the game. fixes CleverRaven#34072
mlangsdorf
added
<Bugfix>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Remove failed craft when losing last component"Purpose of change
fixes #34072 - the AIM was throwing up as the crafts with no components in them had 0 volume.
Describe the solution
Currently, in progress crafts that lose their last component still exist, but with a volume of 0 as there is nothing in them. I've added this fix where if a player/npc bungles a craft and loses the last component of it (and the craft had components to start with), the craft item is removed from the game. Basic rational being how can you have an in-progress craft if you've destroyed all the parts of that craft.
Testing
Tested that a normal character could still successfully make crude wooden arrows (an item with only one component), then tested with a character that would regularly fail the check that they would have the in progress craft removed when they bungled it.