Item_Groups cleanup - Religious Books #35484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have a religious books category -- let's use it! Replacted 90 redundant entries in item_groups.json by calling already existing religious books category.
ZhilkinSerg
added
[JSON]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY: Content "cleaned up item_groups.json by replacing long lists of holybooks by calling religious books list"Purpose of change
json list clean-up
Describe the solution
We have a religious books category -- let's use it! Replaced 90 redundant entries in item_groups.json by calling already existing religious books category.
Describe alternatives you've considered
None
Testing
After de-linting item_groups.json, used debug item group test function and spawned the lists. All religious books spawned as normal.
Additional context