softdrink list added

[LilShiningMan]

SUMMARY: Content "added softdrink_canned list to food.json. Changed item spawn lists in item_groups, locations and food_service to pull from this list."

Purpose of change

There's a lot of clutter and redundant items spread out over item_groups.json and other .json lists. This is an attempt at a little house-cleaning.

Describe the solution

Surveyed item lists in item_groups, food_service and locations .jsons. Took the top 9 most spawned canned soft drinks and put into a master list in food.json. Replaced the nearly identical clusters of drinks in each item list across above .jsons and referenced softdrink_canned instead, preserving the spawn rates by adding up the combined weight of replaced items. This has eliminated somewhere in the neighborhood of 100+ unique entries. Makes it easier to read these lists and also to easily add new items to many lists at once.

Describe alternatives you've considered

None. This is simple house-cleaning.

Testing

.Jsons have all been de-linted. Each item group has been tested using the debug/info/test item group. No perceivable change to spawns.

Additional context

This is all back-end and should not be noticeable to players. I did not re-weight spawns of individual items, so it should be seamless. NOTE: there are other redundancies of the same drinks but in plastic or two-litre bottles. This list is strictly for canned drinks and therefore doesn't address that.

[kevingranade]

Nice, little things like this can really add up over time.