Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Triple damage from falling #35468

Merged
merged 1 commit into from
Nov 12, 2019
Merged

Triple damage from falling #35468

merged 1 commit into from
Nov 12, 2019

Conversation

Night-Pryanik
Copy link
Contributor

Summary

SUMMARY: Balance "Triple damage from falling."

Purpose of change

Closes #35461 - Player aparently takes only one sixth of fall damage.

Describe the solution

Comment in player.cpp states

// so let's assume 1 z-level is comparable to 30 force

While activating "ledge" trap function applies force based on only one third of that value. So I increased damage from falling threefold.
Also I added more informative message about how many stories character has fallen.

Describe alternatives you've considered

Serious rework including apply falling damage mostly to legs (as @SirPendrak suggested), but maybe some other time.

Testing

Climbed up the radio tower and jumped down. Fell down 4 stories, died on landing.
Another testing: fell down 2 stories, got damaged overall for 285 damage (~45 damage on every bodypart). Feels like more realistic to me.

Additional context

None.

@Night-Pryanik Night-Pryanik added Game: Balance Balancing of (existing) in-game features. Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. Mechanics: Character / Player Character / Player mechanics labels Nov 11, 2019
@Nerezza
Copy link
Contributor

Nerezza commented Nov 12, 2019

This is probably something to mess with in another PR, but recently I've had issue with accidentally leaping off a 1-story building's roof instead of carefully climbing down. It might be a good idea to make the "climb down" option the default selected option in the "empty space" interact menu if we're going to make leaping off a building (accidentally) do more than slight damage :P

@kevingranade kevingranade merged commit ea781bd into CleverRaven:master Nov 12, 2019
@Night-Pryanik Night-Pryanik deleted the falling-damage-fix branch November 12, 2019 06:21
AMurkin pushed a commit to AMurkin/Cataclysm-DDA that referenced this pull request Nov 13, 2019
AMurkin added a commit to AMurkin/Cataclysm-DDA that referenced this pull request Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. Game: Balance Balancing of (existing) in-game features. Mechanics: Character / Player Character / Player mechanics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Player aparently takes only one sixth of fall damage.
3 participants