[CR] Updates the contribution description with information regarding open issues #35445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…issues. This should prevent confusion for developers who are used to working in environments where the only changes accepted are ones which reference open issues, and prevent redundant issue submission for PRs that the developer has already implemented.
GediminasMasaitis
changed the title
|
It seems the PR was rejected because the validator is unhappy about the PR, since it doesn't have a |
|
You can choose |
ZhilkinSerg
added
<Documentation>
GediminasMasaitis
deleted the
update-guidelines-about-issue-requirement
branch
AMurkin
pushed a commit
to AMurkin/Cataclysm-DDA
that referenced
this pull request
Nov 13, 2019
…issues. (CleverRaven#35445) This should prevent confusion for developers who are used to working in environments where the only changes accepted are ones which reference open issues, and prevent redundant issue submission for PRs that the developer has already implemented.
AMurkin
added a commit
to AMurkin/Cataclysm-DDA
that referenced
this pull request
Nov 13, 2019
…ng open issues. (CleverRaven#35445)" This reverts commit 068a6c1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: NonePurpose of change
There are open source projects which simply reject any PRs that don't reference open issues. I edited the contribution document, as suggested by
@Mark#9561on discord, to reflect the project's stance on this rule, and prevent confusion whether an issue is required to submit a PR.Describe the solution
Explain that a GitHub issue is not required for a PR, but if none is referenced, the PR should be self-complete, that is - explaining itself fully without external references.