Fixed various profession items issues #35429
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Fixed various profession items issues"
Purpose of change
Fixes several professions having correct charges, ammo, or item placement.
Describe the solution
I noticed a number of professions didn't have the right charges or ammo for some items and weapons. A few also had problems carrying items. The following changes have been made:
Professions that start with quivers or bandolier have the correct amount of ammo instead of 1
I've changed the quiver/bandolier contents to be an "item group" to fix this issue. This was the only way I could find to fix the bug. I recommend someone check the C++ to find why "charges" is not being recognized correctly. The following professions were fixed:
Hardened Survivor's Crossbow starts loaded with a bolt
Simple oversight.
Miner's Jackhammer starts with a full tank of 400 Gasoline charges
No sense having a Jackhammer if you can't use it.
Both Security Guard and Gangster carry 2 clips (15) of their respective ammo instead of 40 bullets
Having just the ammo made it too difficult to reload since you need to reload the magazine and then reload the gun.
Ahistorical Reanactor's Wooden Needle now contains 50 Thread
There is no reason to believe that a sewing needle would not also have thread with it.
The guns worn by Bionic Solider and Sniper now have magazines
This was an oversight that caused the weapons of these professions to start without ammo.
Bionic Surgeon's Medium Battery starts with 500 charges
No one is going to carry around an empty battery.
Camper and Veteran Bandit's Mess Kit starts with a full medium battery
These professions can cook food now!
Boxer no longer wears their Towel
Wearing the towel was causing encumbrance issues. The Hitchhiker still wears their towel since they don't start with pants.
Shower Victim wields their Soap Bar
Shower Victim was the only profession that cannot carry all the items it starts with. To avoid dropping the soap, the Shower Victim now wields it at char gen.
Testing
Go to character creation screen and view the professions to see the changes.