Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed various profession items issues #35429

Merged
merged 1 commit into from
Nov 10, 2019
Merged

Fixed various profession items issues #35429

merged 1 commit into from
Nov 10, 2019

Conversation

Hymore246
Copy link
Contributor

Summary

SUMMARY: Bugfixes "Fixed various profession items issues"

Purpose of change

Fixes several professions having correct charges, ammo, or item placement.

Describe the solution

I noticed a number of professions didn't have the right charges or ammo for some items and weapons. A few also had problems carrying items. The following changes have been made:

Professions that start with quivers or bandolier have the correct amount of ammo instead of 1
I've changed the quiver/bandolier contents to be an "item group" to fix this issue. This was the only way I could find to fix the bug. I recommend someone check the C++ to find why "charges" is not being recognized correctly. The following professions were fixed:

  • Bow Hunter
  • Crossbow Hunter
  • Shotgun Hunter
  • Rifle Hunter
  • SWAT CQC Specialist
  • Bionic Prepper
  • Wild West Gunslinger
  • Naturalist
  • Road Warrior
  • Wasteland Ranger

Hardened Survivor's Crossbow starts loaded with a bolt
Simple oversight.

Miner's Jackhammer starts with a full tank of 400 Gasoline charges
No sense having a Jackhammer if you can't use it.

Both Security Guard and Gangster carry 2 clips (15) of their respective ammo instead of 40 bullets
Having just the ammo made it too difficult to reload since you need to reload the magazine and then reload the gun.

Ahistorical Reanactor's Wooden Needle now contains 50 Thread
There is no reason to believe that a sewing needle would not also have thread with it.

The guns worn by Bionic Solider and Sniper now have magazines
This was an oversight that caused the weapons of these professions to start without ammo.

Bionic Surgeon's Medium Battery starts with 500 charges
No one is going to carry around an empty battery.

Camper and Veteran Bandit's Mess Kit starts with a full medium battery
These professions can cook food now!

Boxer no longer wears their Towel
Wearing the towel was causing encumbrance issues. The Hitchhiker still wears their towel since they don't start with pants.

Shower Victim wields their Soap Bar
Shower Victim was the only profession that cannot carry all the items it starts with. To avoid dropping the soap, the Shower Victim now wields it at char gen.

Testing

Go to character creation screen and view the professions to see the changes.

@mlangsdorf mlangsdorf added <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON Mechanics: Character / Player Character / Player mechanics labels Nov 10, 2019
@ZhilkinSerg ZhilkinSerg merged commit 71b9848 into CleverRaven:master Nov 10, 2019
@irwiss
Copy link
Contributor

irwiss commented Nov 10, 2019

Miner's Jackhammer starts with a full tank of 400 Gasoline charges
No sense having a Jackhammer if you can't use it.

This appears to be intended:
"description": "You're a miner, not a minor! Your canteen is dry, your jackhammer is out of gas, and you're on your last pair of batteries for your mining helmet...",

So either the change should be reverted or description fixed

@Hymore246 Hymore246 deleted the prof-item-fixes branch November 10, 2019 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON Mechanics: Character / Player Character / Player mechanics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants