create item_info_data as parameter for draw_item_info #35428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KorGgenT
added
[C++]
BevapDin
reviewed
Nov 10, 2019
AMurkin
pushed a commit
to AMurkin/Cataclysm-DDA
that referenced
this pull request
Nov 13, 2019
AMurkin
added a commit
to AMurkin/Cataclysm-DDA
that referenced
this pull request
Nov 13, 2019
…Raven#35428)" This reverts commit cc8aa02.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Infrastructure "Change parameters of draw_item_info to a struct"Purpose of change
For ease of understanding what's going on, for ease of only changing one boolean without writing long string of default bools, for ease of expandability with item info. i'm intending to use this to solve
#28180
Describe the solution
just what it says on the tin.
Describe alternatives you've considered
expanding the parameters of this function indefinitely
Testing
ran the game, did some item compares, crafting recipes.
Additional context
No end user should be the wiser. this change should be functionally identical.