Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove inappropriate dispersion_modifier fields #35426

Merged
merged 1 commit into from
Nov 9, 2019

Conversation

ymber
Copy link
Member

@ymber ymber commented Nov 9, 2019

Summary

SUMMARY: Content "Remove dispersion_modifier values from gunmods that don't affect mechanical accuracy"

Purpose of change

Several gunmods that should have no effect on the maximum achievable mechanical accuracy of the weapon they are installed on were affecting that.

Describe the solution

Remove inappropriate dispersion_modifier fields.

Testing

Game loads correctly with no errors and stat impacts of gunmods are as expected.

@SirPendrak
Copy link
Contributor

While removing most of theese makes sense, what about things mounted directly to the end of the barell? Like bipod in some old military rifles, or some bayonets to this day. Additional weight on barrel can affect the accuarcy badly, and mods should be mounted to guns chassis.

@mlangsdorf mlangsdorf added <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON Items: Gunmod / Toolmod Weapon and tool attachments, and add-ons Ranged Ranged (firearms, bows, crossbows, throwing), balance, tactics labels Nov 9, 2019
@ymber
Copy link
Member Author

ymber commented Nov 9, 2019

Anything that affects barrel harmonics would have some kind of impact but given how we model attachment points for these items that isn't applicable to any of them.

@ZhilkinSerg ZhilkinSerg merged commit db0816b into CleverRaven:master Nov 9, 2019
@ymber ymber deleted the mod_stats branch November 9, 2019 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) Items: Gunmod / Toolmod Weapon and tool attachments, and add-ons [JSON] Changes (can be) made in JSON Ranged Ranged (firearms, bows, crossbows, throwing), balance, tactics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants