Add staff sling and ammo

[snipercup]

Summary

SUMMARY: Content "Add staff sling and ammo"

Purpose of change

To add staff sling and ammunition

Describe the solution

While wielding the staff sling, any rocks in the Characters inventory or nearby will automatically be loaded and fired at the closest target. When ammunition is expended the weapon can be used as a quarter staff. There is a very decent chance of recovering rocks allowing multiple uses of limited ammunition.

Describe alternatives you've considered

N/A

Testing

Use the weapon and ammunition during gameplay

Additional context

This content was made by @TJKing293, I'm just doing the PR.

[dissociativity]

Is there a reason that this does not use pebbles like the other sling?
From what I've heard of these, they're pretty much the same as your standard sling, but they should have a bit more range and power than a standard shephard's sling, with the downside of being harder to use (which can be simulated by a bit more dispersion)

Also:
a few notes
A standard quarterstaff has a bashing of 19, it's tailor made for the task of purely being used as a bashing weapon and therefore it should be somewhat more effective than a staff sling, nerf the bash damage to I'd say, 18 or 17, certainly not 25, that would make it one of the better lightweight bashing items.

Is this staff really 6L in volume? that's twice that of a quarterstaff, it'd have to be long enough to make reach attacks to feel justified at that size right?
If it is larger and heavier for a reason than the quarterstaff, perhaps 20 bash is justified considering it's heavier, but no more.

[TJKing293]

it was primarily made to throw small pots of burning oil over the walls of cities. It could in theory throw pebbles but it's range is close to a Sheppard sling just with the ability to throw heavier objects. Plus it had a secondary ability to beat things to death,

[dissociativity]

in this case you may want to classify items like pool balls as ammunition for it too
Do you intend on making a recipe for it and perhaps have it spawn in museums and such like other primitive tools?

You may also want to set up dispersion values and the rest like pebbles, clay pellets, ect already have for any item that this would be applicable to and perhaps make larger craft-able variations of clay pellets, lead bearings and such.

[TJKing293]

I apologize. The recipe was a bit of a oversight. Will be adding it soon. And yes a pool ball would make an excellent projectile.

in its current state it is literally a quarterstaff with a standard sling on the end. I'm not sure how to logically justify nerfing it.

[dissociativity]

in its current state it is literally a quarterstaff with a standard sling on the end. I'm not sure how to logically justify nerfing it.

if it's literally a quarterstaff with with a sling attached, why does it have bashing 25 where again, a quarterstaff has far less of 19?

The sling on the end doesn't really make it any better at bashing lol.

[TJKing293]

in its current state it is literally a quarterstaff with a standard sling on the end. I'm not sure how to logically justify nerfing it.

if it's literally a quarterstaff with with a sling attached, why does it have bashing 25 where again, a quarterstaff has far less of 19?

The sling on the end doesn't really make it any better at bashing lol.

it was changed to 19 from 25. I changed the recipe to use the long stick instead of the quarterstaff and added pool balls in addition to rocks for ammo. It does 18 bash damage now.

[TJKing293]

well I can do one of three things

1. modify the rock item to have ranged damage and some effects along with the characteristics
   2.Make a "sling rock" ammo
   3.say that pebbles when used with this weapon go faster therefore harder and further

[kevingranade]

I prefer the third option, treat slinging as "tool assisted throwing".

…

On Sat, Nov 9, 2019, 5:45 PM TJKing293 ***@***.***> wrote: well I can do one of three things 1. modify the rock item to have ranged damage and some effects along with the characteristics 2.Make a "sling rock" ammo 3.say that pebbles when used with this weapon go faster therefore harder and further — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#35417?email_source=notifications&email_token=AAGSA5GZBZCTT2OGU7KGIZLQS5RS7A5CNFSM4JLCZ3F2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDUTI7A#issuecomment-552154236>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAGSA5G7ULOV6PCZUTUXMRDQS5RS7ANCNFSM4JLCZ3FQ> .

[snipercup]

@TJKing293 changed some things. It does not show any errors anymore and there's no duplicate items. THe rock still works as before but it is now also ammo. This is the result:

You can also craft with it:

[Orinyau]

Is "capacity" the size of it's "magazine"?

If so, I don't think it should be possible to use this as a melee weapon, while it is loaded.

[snipercup]

Is "capacity" the size of it's "magazine"?

If so, I don't think it should be possible to use this as a melee weapon, while it is loaded.

Thanks for your question.
Actually the staff can't be loaded and used as a melee weapon at the same time. Just like the slingshot, when you press f to aim it gets loaded and you can fire. When you press esc to cancel, the ammo is unloaded:

When it is unloaded you can use it as a melee weapon:

[snipercup]

TJKing293 Added recipe:

[Orinyau]

Okay, thanks for clarifying. Sounds good to me.

[TJKing293]

Final recipe

[TJKing293]

as far as I'm concerned when the checks are done it is ready to merge. unless somebody else has any objections.

[RDru]

Getting this error on load:

 DEBUG    : warnings for type staff_sling:
there is no actual ammo of type rock defined


 FUNCTION : void Item_factory::check_definitions() const
 FILE     : src/item_factory.cpp
 LINE     : 1162

[snipercup]

I just downloaded the latest from https://cataclysmdda.org/experimental/. Cannot reproduce your issue. I also spawned and fired the staff sling, no errors show up.

[RDru]

ok, found override for rock in blazemod and that is causing this error

[snipercup]

Ah, that explains. Where is Blazemod hosted? Maybe I can do something to fix it?

[RDru]

here on this git repo in mods :)

[snipercup]

Okay I can fix that.