Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove other zone farming options, deduplication/inconsistency reduction #35390

Merged
merged 1 commit into from Nov 16, 2019
Merged

Conversation

ghost
Copy link

@ghost ghost commented Nov 7, 2019

Summary

SUMMARY: Bugfixes "Remove other zone farming options, deduplication/inconsistency reduction"

Purpose of change

Fixes #35291

Describe the solution

Remove tilling/planting/harvesting zone activities, as they were done from the multi_farm activity anyway.
The appearance of both in the zone activities menu, could be confusing, seeing as they behaved differently anyway, and currently the tilling/planting/harvesting single zone activities were not functioning correctly anyway.
This is not to say that the multifarm zone activity is better in some fundemental way, its just that theres no need for both now, and NPCs use the multifarm zone activity.

I've also made tilling a dark capable activity, so that its consistent with the iuse:: of a shovel/hoe.

I've kept the fertilizing zone activity, as the multifarm activity currently doesnt cover that, but may do in the future.

Describe alternatives you've considered

Fixing the existing tilling/planting/harvest zone activities to work again, but itd still be duplication of features.

Testing

Loaded up game, opened up zone activity menu ( O ) and only "farm plots" showed up, and not " till plots"

Additional context

N/A

@ZhilkinSerg ZhilkinSerg added <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` [JSON] Changes (can be) made in JSON Inventory / AIM / Zones Inventory, Advanced Inventory Management or Zones labels Nov 8, 2019
@ZhilkinSerg ZhilkinSerg merged commit ae3e7fa into CleverRaven:master Nov 16, 2019
@ghost ghost deleted the moree_tilling_consistency branch December 19, 2019 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Inventory / AIM / Zones Inventory, Advanced Inventory Management or Zones [JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent plot tilling using zones vs using digging stick
1 participant