Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove a few pointless round trips for id vs object #35385

Merged
merged 1 commit into from
Nov 7, 2019
Merged

Remove a few pointless round trips for id vs object #35385

merged 1 commit into from
Nov 7, 2019

Conversation

BevapDin
Copy link
Contributor

@BevapDin BevapDin commented Nov 7, 2019

SUMMARY: None

The item already provides the itype object, similar if you have the id to call find_type, why convert the result back into the original ID?

@BevapDin
Remove a few pointless round trips for id vs object
edc58b7 
The `item` already provides the `itype` object, similar if you have the id to call `find_type`, we convert the result back into the original ID?
@ZhilkinSerg ZhilkinSerg added [C++] Changes (can be) made in C++. Previously named `Code` Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style Items / Item Actions / Item Qualities Items and how they work and interact labels Nov 7, 2019
@ZhilkinSerg ZhilkinSerg merged commit b91dac0 into CleverRaven:master Nov 7, 2019
@BevapDin BevapDin deleted the aba branch November 7, 2019 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
[C++] Changes (can be) made in C++. Previously named `Code` Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style Items / Item Actions / Item Qualities Items and how they work and interact
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BevapDin @ZhilkinSerg