Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remoe UB in debug overmap code: #35383

Merged
merged 1 commit into from
Nov 7, 2019
Merged

Remoe UB in debug overmap code: #35383

merged 1 commit into from
Nov 7, 2019

Conversation

BevapDin
Copy link
Contributor

@BevapDin BevapDin commented Nov 7, 2019

SUMMARY: None

mgroup was being dereferenced even when it is null, which is UB.

@BevapDin
Remoe UB in debug overmap code:
f928709 
`mgroup` was being dereferenced even when it is null, which is UB.
@ZhilkinSerg ZhilkinSerg added <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` labels Nov 7, 2019
@ZhilkinSerg ZhilkinSerg merged commit e86228c into CleverRaven:master Nov 7, 2019
@BevapDin BevapDin deleted the tmu branch November 7, 2019 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
<Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code`
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BevapDin @ZhilkinSerg