-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed Coughing during a cold prevents sleeping even when Dead Tired #35372
Conversation
This could lead to eternal sleep if one is coughing too frequently while sleeping? |
Hmmm, I guess that's true it didn't happen with the flu but under the right circumstances it could. Shoot. |
I think the fatigue effect is a really good idea... Could you store how much fatigue is being generated, and have it applied as an effect upon waking up? Maybe with a cap so that at worst you're still not quite as bad as if you hadn't slept at all? |
To prevent infinite sleeping I changed it so that now for five minutes after coughing you only recover half as much fatigue from sleeping. |
That's a very good fix |
…leverRaven#35372) * rebalance cough * Fix cough suppresion and make effects smaller but more frequent * Remove fatigue effect * changed balance to reduce fatigue restore * Changed name to be less confusing
… Tired (CleverRaven#35372)" This reverts commit 3e9c31f.
Re-tested with the saved game from #33588, and i still wake up after 1-3 coughs. |
Oh, that was because i had enhanced hearing enabled. |
Summary
SUMMARY: Bugfixes "Fixed Coughing during a cold prevents sleeping even when Dead Tired"
Purpose of change
Fixes #33588
Fixes cough suppression not preventing stamina loss for prevented harmful coughs
Greatly reduced chances of waking up from coughing. Reduced fatigue recovery shortly after coughing.
Describe the solution
Moved cough suppression return code to top
Removed chance to wake up from cough method. There is still a chance to wake up based on the sound but its more realistically frequent. Added effect coughing for 5 minutes after coughing that reduces fatigue recovery while sleeping
Describe alternatives you've considered
I attempted to build an option to auto retry sleeping after waking, but couldn't get it to feel/work right.
Testing
Additional context