Tailoring overhaul, part 2: Requirements #35304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Doesn't renaming the ID for the nylon break savegame compatibility? Or is it fine as long as no player has this item in their world anyway? |
It shouldn't result in anything bad; before this change it just replaced another item entirely during loading. And either way it should have been unobtainable for now. |
curstwist
added
[JSON]
AMurkin
pushed a commit
to AMurkin/Cataclysm-DDA
that referenced
this pull request
Nov 13, 2019
AMurkin
added a commit
to AMurkin/Cataclysm-DDA
that referenced
this pull request
Nov 13, 2019
This reverts commit 57474f2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Content "Add item crafting requirements used by tailoring overhaul"Purpose of change
https://github.com/CleverRaven/Cataclysm-DDA/projects/25
Describe the solution
Add all the crafting requirement entries related to upcoming tailoring overhaul. Those requirements have no use until all the framework is done to allow rewriting existing recipes to use the new system. Also introduces a small fix to one of previously added items.
Describe alternatives you've considered
None.
Testing
Copy-pasted newly-added requirements to game files, checked that it runs fine.
Additional context
This is a part of #33806.