Change disp_name to be able to return a capitalized name #35287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZhilkinSerg
added
[C++]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Infrastructure "Allow disp_name to return a capitalized name"Purpose of change
When sorting items it would return the message "you sorted out all possible items", with a lower case "you".
Describe the solution
This PR introduces a parameter to disp_name that makes it return upper case names. There are some gotchas (mentioned in the comments for the function)
Describe alternatives you've considered
Capitalizing after grabbing the text, but that is probably not wise when it comes to translation.
Testing
Compiles and runs, showing the proper text with capital if requested.
Additional context