Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add acid resistance spells #35286

Merged
merged 3 commits into from Nov 9, 2019
Merged

Add acid resistance spells #35286

merged 3 commits into from Nov 9, 2019

Conversation

ghost
Copy link

@ghost ghost commented Nov 3, 2019

Summary

SUMMARY: Mods "Add acid resistance spell"

Purpose of change

Acid resistance spell was requested by KorG before full release of the black dragon lair.

Describe the solution

Adds two-tier acid resistance spell, whose scroll recipe is obtained only(per the "SECRET" flag) by finding Black Dragon: Swamp Ruins. 25% resistance aura upgrades to higher cost, half time 60% resistance aura.

Describe alternatives you've considered

Making the 60% resistance spell have equal duration to the normal, axed so the cheaper normal version retains usage for stacking future auras.

Testing

Spawned in Black Dragon: Swamp Ruins to see if recipe appears in book. Took spellcraft 2 at chargen to check if SECRET flag works. Crafted it once.
Damage values vs. Black Dragon Breath from adult:
Nekkid w/ greater aura(60%):
image

Nekkid w/ lesser aura(25%):
image

Nekkid w/ both(85%):
image

Nekkid:

image

Additional context

Using copy-from for relic data ignores attempted overwriting, which was causing the greater aura to give 100% due to 30% from normal being added to 70% greater when numbers were 30/70.

@ghost ghost marked this pull request as ready for review November 3, 2019 18:21
@ZhilkinSerg ZhilkinSerg added [JSON] Changes (can be) made in JSON Mods: Magiclysm Anything to do with the Magiclysm mod Mods Issues related to mods or modding labels Nov 3, 2019
@KorGgenT KorGgenT merged commit 4537b26 into CleverRaven:master Nov 9, 2019
AMurkin pushed a commit to AMurkin/Cataclysm-DDA that referenced this pull request Nov 13, 2019
* Add acid resistance spells

Acid resist spells


Acid resistance scroll & recipe

* Remove greater copy-from, nerf values for stacking exploit

* No 0g & 0ml
AMurkin added a commit to AMurkin/Cataclysm-DDA that referenced this pull request Nov 13, 2019
@ghost ghost deleted the AcidResSpell branch December 2, 2019 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[JSON] Changes (can be) made in JSON Mods: Magiclysm Anything to do with the Magiclysm mod Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants