Allow Large and Huge creatures to move through underbrush #35285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR 35060 changed it so that large and huge creatures could not move through tight passages, using the THIN_OBSTACLE flag. This is incorrect, because the THIN_OBSTACLE flag is widely used on things such as underbrush, that large and huge creatures should be able to move on.
|
This pull request has been mentioned on Cataclysm: Dark Days Ahead. There might be relevant details there: https://discourse.cataclysmdda.org/t/uncomfortably-large-mutant-cant-fit-through-windows/21848/10 |
ZhilkinSerg
added
<Bugfix>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Allow large and huge creatures to move through underbrush"
Purpose of change
#35060 prevents Large and Huge creatures from moving through obstacles with the
THIN_OBSTACLEflag. This is incorrect behavior, because while large and huge creatures should not be able to move through some obstacles, these obstacles should not be selected with theTHIN_OBSTACLEflag, because this flag has another purpose, and is fairly widely used, on other things, such as underbrush.Describe the solution
Add a new flag,
SMALL_PASSAGE, and use that instead.Testing
Make a character, use enough bear mutagen to become large. Attempt to walk through a window frame, open window, and empty window - notice it doesn't let you move through. Attempt to walk over underbrush, and notice that you can.