Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add house_w_6 #35264

Merged
merged 1 commit into from
Nov 3, 2019
Merged

add house_w_6 #35264

merged 1 commit into from
Nov 3, 2019

Conversation

curstwist
Copy link
Contributor

Summary

SUMMARY: Content "Adds new 2 story house.'"

Purpose of change

continue nested house project.

Describe the solution

Added a house.

Testing

Spawned in world a lot to check nest placements and spawns.

Additional context

ground floor:
house_w_6_ground

2nd floor:
house_w_6_2ndfloor

roof:
house_w_6_roof

selection of nests: ground:
nests

selection of nests: 2nd floor:
nests 2

@curstwist curstwist added [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display labels Nov 3, 2019
@Night-Pryanik
Copy link
Contributor

Four bedrooms?

@curstwist
Copy link
Contributor Author

curstwist commented Nov 3, 2019

Do we have a bedroom limit? Because I'm about to make more 4 bedroom ones. Which is a pretty standard layout. 3-4 is typical, especially for 2 story houses. I'm basing them on historical layouts.

@Night-Pryanik
Copy link
Contributor

If it's a standard IRL layout, then I have no more question. It just seems... too many to me.

@mlangsdorf
Copy link
Contributor

both of the two story houses I've lived in had 4 bedrooms. It's an extremely common number in America.

@curstwist
Copy link
Contributor Author

Too many from a potential loot viewpoint or uncommon based on your personal experience? I'm hoping more people will add nested_chunks for these houses, where they could replace some of the bedrooms with other possible rooms as well. Usually it's 1 bedroom for parents, 2 standard for kids, and a guest bedroom/bonus room.

Once I start making more modern houses, they'll often have 3-4 bedrooms and 2 living rooms (family room & formal living room).

If we end up adding more clothing sizes in the tailoring overhaul, I think the loot issue will equalize a lot, and we'll make more specifically children's bedrooms.

@Night-Pryanik
Copy link
Contributor

uncommon based on your personal experience?

This. I've never been in a house with 4 bedrooms.

@ZhilkinSerg ZhilkinSerg merged commit a93a373 into CleverRaven:master Nov 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants