Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autodoc is not autonomous #35234

Merged
merged 7 commits into from
Nov 9, 2019

Conversation

Fris0uman
Copy link
Contributor

@Fris0uman Fris0uman commented Nov 1, 2019

Summary

SUMMARY: Interface "Autodoc warns player that it needs an operator to function"

Purpose of change

Adds a prompt that reminds the player that the Autodoc is not in fact fully autonomous, and that using it without someone in control is very risky
No balance effect, only flavour.

Describe the solution

Check if the player is on the patient couch
If yes gives the prompt

Describe alternatives you've considered

Testing

Additional context

The Autodoc is not autonomous, that's why the risk in using it is so high. However this is not always clear to the player, especially considering the name of the thing. This tries to make thing clearer.
image

@fluffe9911
Copy link
Contributor

I feel like this is going to cause more confusion by making players think they are about to do a computer skills check

@Fris0uman
Copy link
Contributor Author

Computer is already a skill used when using autodoc, using the autodoc was already a computer skill check

@fluffe9911
Copy link
Contributor

fluffe9911 commented Nov 1, 2019

I know but im saying it sounds like one of those ones where if you fek up it locks you out or spawns man hacks or something you know
edit: maybe this is just a me thing but if I see 5 years from now someone asking if there is a chance of bad things happening if I override security measures im gonna be like knew it

src/iexamine.cpp Outdated Show resolved Hide resolved
src/iexamine.cpp Outdated Show resolved Hide resolved
@Destragon
Copy link

Destragon commented Nov 2, 2019

the Autodoc is not in fact autonomous

Should they just get renamed then?

@zeggz
Copy link

zeggz commented Nov 3, 2019

Does it take into acount that you can have an NPC companion performing the operation on you?

src/iexamine.cpp Outdated Show resolved Hide resolved
src/iexamine.cpp Outdated Show resolved Hide resolved
@peperov
Copy link
Contributor

peperov commented Nov 4, 2019

There were many changes to the Autodoc since I've last been playing. Needless to say my cyborg prototype character died horribly while trying to have some faulty bionics removed by the Autodoc.
I was not anticipating that character skill is involved in the operation, especially as the player is under influence of anesthetics (presumably locally... but afterwards it says "wait until you wake up").
Having this prompt might prevent reoccurance of the confusion that I went through.

@Fris0uman Fris0uman marked this pull request as ready for review November 7, 2019 20:11
@ZhilkinSerg ZhilkinSerg added [C++] Changes (can be) made in C++. Previously named `Code` Bionics CBM (Compact Bionic Modules) Info / User Interface Game - player communication, menus, etc. labels Nov 7, 2019
@Night-Pryanik
Copy link
Contributor

Could you please provide a screenshot with new texts?

src/iexamine.cpp Outdated Show resolved Hide resolved
Co-Authored-By: Anton Burmistrov <[email protected]>
@Fris0uman
Copy link
Contributor Author

See Additional context for the screenshot

src/iexamine.cpp Outdated Show resolved Hide resolved
Co-Authored-By: DaviBones <[email protected]>
@ZhilkinSerg ZhilkinSerg merged commit 86b3adc into CleverRaven:master Nov 9, 2019
@Fris0uman Fris0uman deleted the autodoc_is_not_auto branch November 9, 2019 21:27
AMurkin pushed a commit to AMurkin/Cataclysm-DDA that referenced this pull request Nov 13, 2019
AMurkin added a commit to AMurkin/Cataclysm-DDA that referenced this pull request Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bionics CBM (Compact Bionic Modules) [C++] Changes (can be) made in C++. Previously named `Code` Info / User Interface Game - player communication, menus, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants