Move activate_mutation and deactivate_mutation to Character #35227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
curstwist
added
[C++]
KorGgenT
reviewed
Nov 2, 2019
src/character.cpp
Outdated
| return invoke_item( used, use_methods.begin()->first, pt ); | ||
| } | ||
|
|
||
| uilist umenu; |
There was a problem hiding this comment.
anything with a uilist really should be in avatar. that means this function(the other three should stay) should get something basic in Character and the real function in avatar
There was a problem hiding this comment.
The function is used by npc, and since the overload with the uilist calls the other overload I don't think I can only move that one.
|
maybe add another commit that goes through all of the |
added 2 commits
November 2, 2019 17:49
Qrox
reviewed
Nov 4, 2019
src/character.cpp
Outdated
| return invoke_item( used, pos() ); | ||
| } | ||
|
|
||
| bool Character::invoke_item( item *used, const tripoint &pt ) |
There was a problem hiding this comment.
Suggested change
| bool Character::invoke_item( item *used, const tripoint &pt ) | |
| bool Character::invoke_item( item *, const tripoint &pt ) |
AMurkin
pushed a commit
to AMurkin/Cataclysm-DDA
that referenced
this pull request
Nov 13, 2019
AMurkin
added a commit
to AMurkin/Cataclysm-DDA
that referenced
this pull request
Nov 13, 2019
…leverRaven#35227)" This reverts commit e72fde2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Infrastructure "Move activate_mutation and deactivate_mutation to Character"Purpose of change
Part of #34721
has_enough_chargesconsume_chargesinvoke_itemprint_healthactivate_mutationdeactivate_mutationDescribe the solution
Describe alternatives you've considered
Testing
Compile without error
Additional context