alcohol list revamp and move from item_groups.json to food.json #35178
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Summary: [Content] "Alcohol list revamped and moved to food.json"
Purpose of change
The item_groups.json list is unwieldy and filled with lists that could be slotted into the other .jsons in the itemgroups folder. Additionally, I wanted an easy way of calling a main list of liquor to populate in liquor cabinets in my houses. I figured I would partially address the first issue while solving the second issue.
Describe the solution
I moved alcohol main list and sublists (wines_worthy, alcohol_bottled_canned) from item_groups.json to food.json. I combined all alcohol items from both listsand broke down into sub-category lists: beer, wines_worthy (I kept this rather than adding or changing it), liquor, mixed_drinks, misc_alcohol. I added these sublists to the two main alcohol lists (alcohol, alcohol_bottled_canned). I found the previous values of those lists curious because while it might be assumed that the alcohol list would definitely list all of the alcoholic drinks in-game, it was partially complete compared to alcohol_bottled_canned. I swapped the values of those two lists to reflect alcohol being the main catch-all list and alcohol_bottled to what might be bought in a store.
Describe alternatives you've considered
In terms of organizing, no real alternative. For my own purposes, I could have created my own item list, but I thought this would be more beneficial to the community.
Testing
After de-linting these entries, I ran the item list spawn in-game and it produced results much as it should.
Additional context
I wanted to mention that the chem_ethanol item was included in the original alcohol lists, which I find curious as it's more often used to produce spirits or for industrial purposes. I left it in the misc_alcohol list but reduced the spawn rate from 10 to 2. There are other minor spawn weighting changes but I've mostly maintained the spawn rates as found in the original lists. The one exception: I reduced barley wine from a whopping 24(!) to 2 to reflect it being more of a niche/seasonal beer.