Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alcohol list revamp and move from item_groups.json to food.json #35178

Conversation

LilShiningMan
Copy link
Contributor

@LilShiningMan LilShiningMan commented Oct 31, 2019

Summary

Summary: [Content] "Alcohol list revamped and moved to food.json"

Purpose of change

The item_groups.json list is unwieldy and filled with lists that could be slotted into the other .jsons in the itemgroups folder. Additionally, I wanted an easy way of calling a main list of liquor to populate in liquor cabinets in my houses. I figured I would partially address the first issue while solving the second issue.

Describe the solution

I moved alcohol main list and sublists (wines_worthy, alcohol_bottled_canned) from item_groups.json to food.json. I combined all alcohol items from both listsand broke down into sub-category lists: beer, wines_worthy (I kept this rather than adding or changing it), liquor, mixed_drinks, misc_alcohol. I added these sublists to the two main alcohol lists (alcohol, alcohol_bottled_canned). I found the previous values of those lists curious because while it might be assumed that the alcohol list would definitely list all of the alcoholic drinks in-game, it was partially complete compared to alcohol_bottled_canned. I swapped the values of those two lists to reflect alcohol being the main catch-all list and alcohol_bottled to what might be bought in a store.

Describe alternatives you've considered

In terms of organizing, no real alternative. For my own purposes, I could have created my own item list, but I thought this would be more beneficial to the community.

Testing

After de-linting these entries, I ran the item list spawn in-game and it produced results much as it should.

Additional context

I wanted to mention that the chem_ethanol item was included in the original alcohol lists, which I find curious as it's more often used to produce spirits or for industrial purposes. I left it in the misc_alcohol list but reduced the spawn rate from 10 to 2. There are other minor spawn weighting changes but I've mostly maintained the spawn rates as found in the original lists. The one exception: I reduced barley wine from a whopping 24(!) to 2 to reflect it being more of a niche/seasonal beer.

moved alcohol main list and sublists from item_groups.json to food.json. Combined all alcohol items and broke down into sub-category lists: beer, wines_worthy( kept this rather than adding or changing it), liquor, mixed_drinks, misc_alcohol. Added these sublists to 2 main alcohol lists (alcohol, alcohol_bottled_canned) and swapped the values of those two lists to reflect alcohol being the main catch-all list and alcohol_bottled what might be bought in a store.
@LilShiningMan LilShiningMan changed the title alcohol list revamp and move to from item_groups.json to food.json alcohol list revamp and move from item_groups.json to food.json Oct 31, 2019
@Brytenwalda
Copy link
Contributor

I added several new types of alcohol. Perhaps you could wait for a while until my changes are merged?

#35164

Copy link
Member

@anothersimulacrum anothersimulacrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't move things to a different file and change them in the same PR. If you must, please do it in separate commits.
This makes it very hard to see what changes you made.
(That said, I like what you're doing with these).

@OrenAudeles
Copy link
Contributor

Summary line malformed, remove square brackets from around category

@LilShiningMan LilShiningMan deleted the LSM---Alcohol-List-update branch October 31, 2019 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants