Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hoist unvisited member options to globals #35073

Closed

Conversation

esotericist
Copy link
Contributor

Summary

SUMMARY: Bugfixes "hoist unvisited member options to globals"

Purpose of change

Changes in #35065 significantly helped with loading performance, but can cause the game to crash on exit, due to attempting to use data that had already been freed by that point in the exit process

Describe the solution

add global variables for the settings involved

this also has the side benefit of being slightly less expensive than an option test with a string parameter.

Describe alternatives you've considered

could make the unvisited member reports a compile-time option, but i kind of liked the idea of being able to turn on this kind of reporting on the fly without a rebuild

this solution is nearly as fast anyway.

Testing

build it, run it, quit it, push it

Additional context

in the process of working on this i discovered some of these config globals are declared in game.h which is absolutely not where they belong.

at some point they should be migrated to options.h because they're options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant