Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix COP .357 Derringer name, give .357 compatibility #34941

Merged
merged 1 commit into from Oct 23, 2019
Merged

Fix COP .357 Derringer name, give .357 compatibility #34941

merged 1 commit into from Oct 23, 2019

Conversation

ghost
Copy link

@ghost ghost commented Oct 22, 2019

Summary

SUMMARY: Bugfixes "COP .357 Derringer fires .357/.38"

Purpose of change

Was sent a comment on #34666 about obsoleting the "COP .38," which is actually the COP .357 Derringer.

Describe the solution

Changed gun's name to its real name, added compatibility to the cartridge it's marketed for using(it can also fire .38 Special, so that was kept). Also changed the description to describe how it operates the four barrels & remove redundancy of referring to itself by name.

Describe alternatives you've considered

Don't change the description.

Testing

Spawned in COP .357 Derringer, loaded it with both .357 Magnum and .38 Special.
image

Additional information

Original comment:
image

@ghost ghost changed the title Fix COP Derringer name, give .357 compatibility Fix COP .357 Derringer name, give .357 compatibility Oct 22, 2019
@tenmillimaster tenmillimaster added <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON Ranged Ranged (firearms, bows, crossbows, throwing), balance, tactics Items / Item Actions / Item Qualities Items and how they work and interact labels Oct 23, 2019
@ZhilkinSerg ZhilkinSerg merged commit 9cd044f into CleverRaven:master Oct 23, 2019
@ghost ghost deleted the COPFix branch October 28, 2019 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) Items / Item Actions / Item Qualities Items and how they work and interact [JSON] Changes (can be) made in JSON Ranged Ranged (firearms, bows, crossbows, throwing), balance, tactics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants