Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serialize requirements for fetch activity #34907

Merged
merged 9 commits into from Oct 22, 2019
Merged

Serialize requirements for fetch activity #34907

merged 9 commits into from Oct 22, 2019

Conversation

ghost
Copy link

@ghost ghost commented Oct 20, 2019

Summary

SUMMARY: Bugfixes "Serialize requirements for fetch activity"

Purpose of change

Fixes #34874

Describe the solution

This makes some changes to save/loading to enable NPCs to continue where they left off with their activities after loading. It saves automove route and destination_activity properly so npcs can have that restored, and sets up a proper serialization for requirement_data, so that custom requirements created on the fly during gameplay can be stored and retrieved.

Describe alternatives you've considered

N/A

Testing

Told an NPC to go and chop some trees, with a wood axe nearby, while they were walking toward the wood axe, I saved and loaded, they remembered they were walking there, and when they got there and retrieved the requirement_id stored in the backlog activity, it still pointed to a valid requirement_data object, as that had been reconstructed on load.

Also tested with construction, and they remembered their requirements there too, but this also revealed that currently, NPCs are not repeating the construction task after fetching, but thats something seperate Ill look at.

Additional context

N/A

@KorGgenT KorGgenT added [C++] Changes (can be) made in C++. Previously named `Code` NPC / Factions NPCs, AI, Speech, Factions, Ownership labels Oct 20, 2019
src/character.h Outdated Show resolved Hide resolved
src/savegame_json.cpp Outdated Show resolved Hide resolved
src/savegame_json.cpp Outdated Show resolved Hide resolved
src/savegame_json.cpp Outdated Show resolved Hide resolved
src/savegame_json.cpp Outdated Show resolved Hide resolved
src/savegame_json.cpp Outdated Show resolved Hide resolved
src/savegame_json.cpp Outdated Show resolved Hide resolved
@ZhilkinSerg ZhilkinSerg merged commit 4cfc071 into CleverRaven:master Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C++] Changes (can be) made in C++. Previously named `Code` NPC / Factions NPCs, AI, Speech, Factions, Ownership
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NPCs abandon tasks after game reload
2 participants