Add result for "no seed" farm zone type to avoid invalid recipe error #34890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1489,6 +1489,11 @@ static activity_reason_info can_do_activity_there( const activity_id &act, playe | |||
| // do we have the required seed on our person? | |||
| const auto options = dynamic_cast<const plot_options &>( zone.get_options() ); | |||
| const std::string seed = options.get_seed(); | |||
| // If its a farm zone with no specified seed, and we've checked for tilling and harvesting. | |||
| // then it means no further work can be done here. | |||
| if( seed == "No seed" ) { | |||
There was a problem hiding this comment.
Shouldn't we check for something like itype_id( "null" ) instead of plain string?
There was a problem hiding this comment.
The zone "options" are setup to store it as "No seed" which is what options.get_seed() outputs as, it dosnt output with an itype_id.
see in clzones.cpp get_seed() just returns seed which is a string of "No seed" when no seed itype has been specified, though I guess that area could be changed, to return something other than the string of the seed name/ "No seed".
std::vector<seed_tuple> seed_entries = iexamine::get_seed_entries( seed_inv ); seed_entries.emplace( seed_entries.begin(), seed_tuple( itype_id( "null" ), _( "No seed" ), 0 ) );
ZhilkinSerg
added
<Bugfix>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Add result for "no seed" farm zone type to avoid invalid recipe error"Purpose of change
Fixes #34780
Describe the solution
Adds an if clause if the farm zone has "no seed" type, if so, it then returns that no further work can be done there.
Describe alternatives you've considered
N/A
Testing
Before this change : create farm zone with "no seed" as the type., get an error about invalid recipe id.
After this change : the error no longer pops up.
Additional context
N/A