Fix the alignment of many unicode strings #34886
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Interface "Assorted string alignment fixes"
Purpose of change
Fix the incorrect alignment of many strings when they contain unicode characters.
Describe the solution
Used
utf8_width
instead ofstring::size/length
to calculate the display width of strings. Three new functionsleft_justify
,right_justify
, andutf8_justify
were added and used instead of%<num>s
to correctly handle the left/right justifying of utf8 strings.Replaced some
string::size/length
calls used for emptyness check/access to the last element withstring::empty/back
.Also fixed a bunch of small bugs/issues I encountered when testing the changes:
Testing
All fixes were tested in-game and were working as expected.