Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increased shop stock #34869

Closed
wants to merge 54 commits into from
Closed

Increased shop stock #34869

wants to merge 54 commits into from

Conversation

crazykiddeath
Copy link
Contributor

@crazykiddeath crazykiddeath commented Oct 19, 2019

Summary

SUMMARY: "To increase the general stock in shops and commercial district to be more inline with what such places would be stocked with."

Purpose of change

To increase the general stock in shops and commercial district to be more inline with what such places would be stocked with.

Describe the solution

Went through the JSON files for shops, restaurants etc and increased common loot amounts and drop chances.

Describe alternatives you've considered

Reducing rare loot, leaving it as is.

mapgen.zip

@ymber
Copy link
Member

ymber commented Oct 19, 2019

You've got all kinds of stuff in here that isn't meant to be. Keep your changes separate and use feature branches.

@crazykiddeath
Copy link
Contributor Author

crazykiddeath commented Oct 19, 2019

You've got all kinds of stuff in here that isn't meant to be. Keep your changes separate and use feature branches.

Sorry, trying to figure it out right now

@ZhilkinSerg ZhilkinSerg added Items / Item Actions / Item Qualities Items and how they work and interact Map / Mapgen Overmap, Mapgen, Map extras, Map display Spawn Creatures, items, vehicles, locations appearing on map labels Oct 20, 2019
@Kodiologist
Copy link
Contributor

I always assumed that there's less stuff than you'd see in a real store because by the time the player gets to a store, it's already been mostly looted by other people.

@anothersimulacrum
Copy link
Member

PR doesn't mention it, but I believe it's attempting to address #34432.

@I-am-Erk
Copy link
Member

I strongly agree with this PR in spirit, but you've got a heck of a mess going on here. Stop deleting and replacing files, create a new branch from master, put only your changes on it, and PR that.

@crazykiddeath
Copy link
Contributor Author

I strongly agree with this PR in spirit, but you've got a heck of a mess going on here. Stop deleting and replacing files, create a new branch from master, put only your changes on it, and PR that.

Is there some way to remove this pull request so I can do this properly?

@anothersimulacrum
Copy link
Member

Is there some way to remove this pull request so I can do this properly?
You can close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Items / Item Actions / Item Qualities Items and how they work and interact Map / Mapgen Overmap, Mapgen, Map extras, Map display Spawn Creatures, items, vehicles, locations appearing on map
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants