Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encapsulate Stamina #34861

Merged
merged 15 commits into from
Oct 26, 2019
Merged

Encapsulate Stamina #34861

merged 15 commits into from
Oct 26, 2019

Conversation

Fris0uman
Copy link
Contributor

@Fris0uman Fris0uman commented Oct 19, 2019

Summary

SUMMARY: Infrastructure "Encapsulate Stamina"

Purpose of change

Encapsulate Stamina and move get_stamina_max, burn_move_stamina and update_stamina from player to Character
Part of #34721

Describe the solution

Describe alternatives you've considered

Testing

Additional context

Requires #34844

@ZhilkinSerg ZhilkinSerg added [C++] Changes (can be) made in C++. Previously named `Code` Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style labels Oct 19, 2019
@Fris0uman Fris0uman marked this pull request as ready for review October 20, 2019 17:02
@KorGgenT
Copy link
Member

image

this means you need to update savegame_json.cpp, specifically Character::store() and Character::load() and have it save and load this value. also there are conflicts now.

@kevingranade kevingranade merged commit 8f0b78f into CleverRaven:master Oct 26, 2019
@Fris0uman Fris0uman deleted the stamin_stuff branch April 28, 2020 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C++] Changes (can be) made in C++. Previously named `Code` Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants