iuse_actor::can_use parameter change to Character and dependent functions #34855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KorGgenT
added
[C++]
ifreund
reviewed
Oct 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Infrastructure "iuse_actor::can_use parameter change to Character and dependent functions"Purpose of change
part of #34721 on the way to completing #34807
the next step after this is to work on player::invoke_item.
Describe the solution
first, change all the iuse_actor::can_use() stuff from the player parameter to Character, then follow the dependecies down and change scope as I go.
Testing
Compiled successfully.
Spawned a lighter, set some trees on fire. this should exercise a large portion of the code, as can_use is on firestarter_actor and then it should propogate down.