Vehicle parts JSON update #34850
Merged
Vehicle parts JSON update #34850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The awkwardness of copy-from behaving strangely regarding requirements was one of the main reasons I decided this needed to be done. |
ZhilkinSerg
added
<Bugfix>
|
I tested this PR. JSON loaded without errors, use the interface to skim over the parts when installing a part, no errors came up. Uninstalled 2 parts without problems. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Infrastructure "Remove all of the legacy vehicleparts JSON"Purpose of change
Updates the JSON for all vehicle parts to not use the old legacy code.
Incidentally:
Fixes #34741 - Swappable storage batteries required welders to install into a storage battery case
Describe the solution
Remove the difficulty field from all vehicle parts. Remove all old tool based flags. Add in the calculated requirements based on the legacy conversion code.
There were also a couple of what I felt were common sense fixes to install/removal/repair times, but honestly the entire lot needs to be checked more thoroughly for balance.
Describe alternatives you've considered
Allow the legacy code to exist
Testing
I have concretely tested the installation of every single part in the mainline, as well as blaze.
Testing the removal of parts is a much more complicated endeavor, and while I am working on it when I can that's a lot of things to actually test in-game instead of just relying on the JSON checker not throwing any errors.