Fixed inactive incendiary grenades not exploding if thrown in fire #34769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to their "_act" variants and then become active if thrown in fire
Night-Pryanik
added
Items / Item Actions / Item Qualities
Night-Pryanik
deleted the
inactive-incendiary-grenades-will-explode-when-thrown-in-fire
branch
Ramza13
pushed a commit
to Ramza13/Cataclysm-DDA
that referenced
this pull request
Oct 22, 2019
…leverRaven#34769) * Transformable items with ACT_IN_FIRE and BOMB flags will transform into their "_act" variants and then become active if thrown in fire * Get rid of hardcoded name and use target item id
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Fixed inactive incendiary grenades not exploding if thrown in fire."Purpose of change
Closes #32276 - Incendiary grenade activates in fire but doesn't explode.
Describe the solution
When thrown in fire, transformable items with
ACT_IN_FIREandBOMBflags will transform to their transform-targets and then become active.Describe alternatives you've considered
Remove
ACT_IN_FIREflag from both types of incendiary grenades and add aexplode_in_fire: truefield to them. But that didn't worked out.Testing
Spawned a fire. Spawned an inactive incendiary grenade. Threw grenade into a fire. Boom!
Additional context
None.