Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertical move effects #34732

Merged
merged 7 commits into from
Oct 14, 2019
Merged

Conversation

Ramza13
Copy link
Contributor

@Ramza13 Ramza13 commented Oct 14, 2019

Summary

SUMMARY: Bugfixes "Player can move up and down stairs while grappled "

Purpose of change

Fixes #12736 Player can move up and down stairs while grappled

Describe the solution

As pointed out by commenter on linked PR just needed to call move_effects in vertical move method.

Describe alternatives you've considered

Testing

Additional context

@anothersimulacrum
Copy link
Member

The line under Purpose of change shouldn't be in ``, otherwise GitHub won't recognize the Fixes and close the appropriate issue automatically.

@ZhilkinSerg ZhilkinSerg added <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Mechanics: Character / Player Character / Player mechanics Mechanics: Effects / Skills / Stats Effects / Skills / Stats labels Oct 14, 2019
@ZhilkinSerg ZhilkinSerg merged commit 44701e0 into CleverRaven:master Oct 14, 2019
Ramza13 added a commit to Ramza13/Cataclysm-DDA that referenced this pull request Oct 22, 2019
@Ramza13 Ramza13 deleted the vertical_move_effects branch November 17, 2021 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Mechanics: Character / Player Character / Player mechanics Mechanics: Effects / Skills / Stats Effects / Skills / Stats
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Player can move up and down stairs while grappled
3 participants